Remove StringUtil::atoll, convert caller to absl::SimpleAtoi#6707
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Apr 25, 2019
Merged
Remove StringUtil::atoll, convert caller to absl::SimpleAtoi#6707htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Dan Noé <dpn@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
absl::SimpleAtoitakesabsl::string_viewargument and can replace all of the calls toStringUtil::atollthat are using Base 10 conversion, which turns out to be all of them. This PR removesStringUtil::atollentirely and migrates all callers toabsl::SimpleAtoi.Risk Level: Low
Testing:
bazel test //test/...Docs Changes: N/A
Release Notes: N/A
Part of: Issue #6580
Signed-off-by: Dan Noé dpn@google.com